Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CHANGELOG.md #264

Merged
merged 17 commits into from
Jul 18, 2024
Merged

Correct CHANGELOG.md #264

merged 17 commits into from
Jul 18, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

Looks like when we accidentally release 1.8.0 for dbt-adapters we forgot to clean up the changelog

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt
Correct CHANGELOG.md
0cd8f73 
Looks like when we accidentally release 1.8.0 for dbt-adapters we forgot to clean up the changelog
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner July 16, 2024 22:50
@cla-bot cla-bot bot added the cla:yes label Jul 16, 2024
@mikealfare
Copy link
Contributor

The incremental files in .changes need to be updated too. The entries need to be moved into the correct file and all of the 1.8 and later files need to be deleted.

@mikealfare mikealfare self-assigned this Jul 17, 2024
@mikealfare mikealfare requested a review from dbeatty10 July 17, 2024 19:43
dbeatty10
dbeatty10 previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The only other thing that stands out are no hyperlinks to the source issue/PR within the changelogs

For example, dbt-snowflake includes links like this:
image

But if we want to include those hyperlinks (I find them very handy!), that can totally be handled in a separate PR.

@mikealfare
Copy link
Contributor

All of the changes are in the paths-ignore argument of the changelog check, hence it's not running.

dbeatty10
dbeatty10 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 👍

@mikealfare mikealfare enabled auto-merge (squash) July 18, 2024 22:10
@mikealfare mikealfare merged commit e3465c2 into main Jul 18, 2024
15 checks passed
@mikealfare mikealfare deleted the colin-rogers-dbt-patch-1 branch July 18, 2024 22:12
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Sep 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@mikealfare mikealfare mikealfare approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @mikealfare @dbeatty10